search

OCA / maintainer-tools

Odoo Maintainers Tools & conventions for OCA members which evaluate and maintain repositories.
GNU Affero General Public License v3.0
277 stars 459 forks source link

[RFC] remove OCA_PROJECTS dictionary #410

Open sbidoul opened 5 years ago

sbidoul commented 5 years ago

Soon, the reference data for which PSC is in charge of which repo will be in the odoo-community.org database.

I therefore propose to drop the hard coded dictionary in tools/oca_projects.py.

pedrobaeza commented 5 years ago

Well, it's still used in some tools in OCA/maintainer-tools, and connecting to OCA instance is not something feasible.

sbidoul commented 5 years ago

@pedrobaeza which tools are you referring to? I see only check_contrib which is old and most probably never unused. It's also easy to adapt.

I've personally never been in a situation where using this list without being connected to GitHub was really necessary.

I want to progressively simplify the repo creation process, and this is one of the steps that we could remove.

pedrobaeza commented 5 years ago

Last PR for publishing modules is based on it for example: #409

But OCA bot also uses it: https://github.com/OCA/maintainer-tools/blob/92383c9fd8993b2b02de75564b0879aee8d5107f/tools/main_branch_bot.py#L55

sbidoul commented 5 years ago

That is fine. I don't want to kill oca_project.py, I want to kill the hard-coded OCA_PROEJCTS constant in it.

pedrobaeza commented 5 years ago

OK, then I think we can strip it.