OCA / maintainer-tools

Odoo Maintainers Tools & conventions for OCA members which evaluate and maintain repositories.
GNU Affero General Public License v3.0
267 stars 448 forks source link

OCA/timesheet repo not synced to Odoo Apps? #482

Open alexey-pelykh opened 3 years ago

alexey-pelykh commented 3 years ago

@sbidoul @pedrobaeza I think you two the most knowledgable on this: https://apps.odoo.com/apps/modules/browse?search=brainbean lists modules from timesheet repo only, and that's clearly outdated. All other modules (from other repos) have been updated successfully.

sbidoul commented 3 years ago

@alexey-pelykh this is how it looks like. There was no error displayed until I manually clicked the scan button. Maybe their auto scan feature is broken? Anyway, see the hr_timesheet_sheet dependency error...

image

alexey-pelykh commented 3 years ago

@sbidoul wow, that's a bunch of errors. So it seems there's at least dependency issue and ownership issue (this one makes no sense at all)

alexey-pelykh commented 3 years ago

Oh, actually it's the "hr_timesheet_sheet" module that's published from other account (it seems) that's causing the issue. I believe w/o reaching out to Odoo admins it won't be fixable?

sbidoul commented 3 years ago

Yes someone has to reach out to apps.odoo.com admins. hr_timesheet_sheet obviously belongs to Odoo SA on older branches. I don't know if a name can be owned by different orgs on different branches.

alexey-pelykh commented 3 years ago

Oooooh, yeah, that could be an issue. Who of OCA has the power and mandate to outreach Odoo SA regarding this matter?

sbidoul commented 3 years ago

Feel free to give it a try :shrug:

pedrobaeza commented 3 years ago

I think the only solution is to rename our module.

alexey-pelykh commented 3 years ago

cc @astirpe @MiquelRForgeFlow as well

alexey-pelykh commented 3 years ago

@pedrobaeza I guess that's related then for all modules that OCA took over?

pedrobaeza commented 3 years ago

Yes. Sometimes is better that is not shown in apps (like mrp_subcontracting v12 backport, that we don't want to rename when migrating to v13). But for OCA/payroll, we renamed the fw-ported modules to v13, as now they follow a different path from enterprise ones.

alexey-pelykh commented 3 years ago

I wonder how those conflicting modules were published before 🤔 Odoo SA did not perform checks or something like that. Do we have modules that have same name as EE ones from same version?

pedrobaeza commented 3 years ago

I don't get your question.

sbidoul commented 3 years ago

I wonder how those conflicting modules were published before

I think they were never published on apps.odoo.com. I very much doubt Odoo will change the policy regarding name ownership across branches. I think this has been discussed before.

Do we have modules that have same name as EE ones from same version?

We should really avoid that.

alexey-pelykh commented 3 years ago

I think they were never published on apps.odoo.com.

Guess you're right, since https://apps.odoo.com/apps/modules/12.0/hr_timesheet_sheet leads to nowhere and fact that https://apps.odoo.com/apps/modules/12.0/hr_timesheet_sheet_activity was somehow published before only means that apps.odoo.com did not perform check (or that was only a warning) about missing dependency?

alexey-pelykh commented 3 years ago

I very much doubt Odoo will change the policy regarding name ownership across branches. I think this has been discussed before.

Yeah, that has no value to them I guess, so why bother. Thus question transforms "what OCA going to do about that and its policies" I guess. As @pedrobaeza mentioned renaming, it seems like only alternative to "doing nothing and using own app store"

pedrobaeza commented 3 years ago

I'm not caring at all for my modules in Odoo Apps since a lot...

alexey-pelykh commented 3 years ago

@pedrobaeza do you have a proper point of contact for such a talk in Odoo SA? It would be great to tag them here and see what would be the result :)

pedrobaeza commented 3 years ago

Nop, the interaction is through apps at odoo dot com.

alexey-pelykh commented 3 years ago

Well, as we assumed, they've said that our best bet is to rename our modules