OCA / maintainer-tools

Odoo Maintainers Tools & conventions for OCA members which evaluate and maintain repositories.
GNU Affero General Public License v3.0
277 stars 459 forks source link

Update our tooling to support Odoo 16.0 #537

Closed sbidoul closed 1 year ago

sbidoul commented 2 years ago

What needs to be done to create the 16.0 branches

See #509 for links to similar PRs for 15.0.

pedrobaeza commented 2 years ago

I can create the OCB 16.0 branch

legalsylvain commented 2 years ago

Hi @sbidoul, could you add :

pedrobaeza commented 2 years ago

OCB branch created: https://github.com/OCA/OCB/tree/16.0

pedrobaeza commented 2 years ago

And the OCB sync script updated at https://github.com/OCA/maintainer-tools/pull/538

carmenbianca commented 2 years ago

I'll have a look at oca-ci.

carmenbianca commented 2 years ago

oca-ci PR: https://github.com/OCA/oca-ci/pull/37

sbidoul commented 2 years ago

runboat is up for OCB 16.0: https://runboat.odoo-community.org/builds?repo=oca/ocb

sbidoul commented 2 years ago

If anyone wants to try updating the repo template, that is welcome as I have little available time this week. Mostly, we need to pick-up the latest linters (doing a dry-run of pre-commit autoupdate on an existing repo will give the versions to use), and determine which pylint-odoo rules to make mandatory, and the new ones to enable.

lmignon commented 2 years ago

@sbidoul I'll take a look at the repo template.

lmignon commented 2 years ago

oca-addons-repo-template PR: https://github.com/OCA/oca-addons-repo-template/pull/160

lmignon commented 2 years ago

looking at oca-github-bot, the only thing that would need to be changed is the config on the server in the environment file to add version 16.0 in MAINTAINER_CHECK_ODOO_RELEASES

pedrobaeza commented 2 years ago

Why not adding from 16.0 to for example 20.0 for not having to worry about this part in some years?

lmignon commented 2 years ago

IMO the topics determine python and postgres version to use in CI and update [addons repo template](https://github.com/OCA/maintainer-tools/issues/github.com/oca/oca-addons-repo-template) can be ticked as done. For the record I manually created the 16.0 branch on the rest-framework repo and created a first PR to check that runboat works as expected with odoo 16.0. -> :champagne:

pedrobaeza commented 2 years ago

Should we proceed with the 16.0 branches creation? @sbidoul are you going to do like other years?

sbidoul commented 2 years ago

I'll do it yes. I was planning to do it this weekend if everything is ready.

Last open question I think is the pylint configs: https://github.com/OCA/oca-addons-repo-template/pull/160#issuecomment-1258552425

sbidoul commented 2 years ago

I prepared OCA/social: https://github.com/OCA/social/issues/974. All looking good. Still waiting a little bit for input about pylint-odoo before opening all other repos.

TheMule71 commented 2 years ago

Hi. I don't really know how to propose changes to Wiki pages (the edit buttton escapes me), so I'm gonna add a comment here.

IMHO the following items are worth considering as additions to the guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0:

pedrobaeza commented 2 years ago

Hi, Marco, I'm afraid GitHub doesn't still offer any way to do such suggestion (or that seems so - https://stackoverflow.com/questions/10642928/how-can-i-make-a-pull-request-for-a-wiki-page-on-github).

Anyway, the changes we put there are the framework ones, not the data model ones, as this last category is very long (see https://github.com/OCA/OpenUpgrade/pull/3583 for the whole list of changes), and it will lose the focus of the guide, as you may not need to know those changes to make the migration (it depends on what are you touching).

TheMule71 commented 1 year ago

It makes sense, thanks.