OCA / maintainer-tools

Odoo Maintainers Tools & conventions for OCA members which evaluate and maintain repositories.
GNU Affero General Public License v3.0
271 stars 454 forks source link

Mention `oca-port` in migration procedure wiki page #589

Open sbidoul opened 10 months ago

sbidoul commented 10 months ago

I'm under the impression that oca-port is ~not~ now mature enough to recommend in the migration procedure wiki page.

What do people think?

@sebalix would you be able to propose that (while keeping the manual procedure in the document for now)?

pedrobaeza commented 10 months ago

In any case, it should be odoo-module-migrator instead.

sbidoul commented 10 months ago

Why "instead"? In my understanding they are complementary tools, with oca-port caring about the branch creation and cherry-picking, while odoo-module-migrator is to transform the source code. That's why I created a separate issue.

pedrobaeza commented 10 months ago

I think odoo-module-migrator does also the commit history fetching.

sebalix commented 10 months ago

Yes odoo-module-migrator does the git format-patch as well, that's the only common point I think, otherwise oca-port is only about playing with git repositories/commits, while odoo-module-migrator deals with code transformation in respect to the targeted Odoo version. In fact it could be called after oca-port process during a migration.

@sbidoul agree, oca-port is not mature enough, and we aim to change a bit the input parameters so I would not recommend this tool yet in the migration guide.

sbidoul commented 10 months ago

agree, oca-port is not mature enough, and we aim to change a bit the input parameters so I would not recommend this tool yet in the migration guide.

Ow, I had mistyped "not" where I meant "now mature" enough. But, good to now there are still changes upcoming in the CLI. Thanks for the update.

sebalix commented 10 months ago

That said, odoo-module-migrator exists since a long time so it deserves to be mentioned in the doc. Once I'm confident with oca-port stability, and if it doesn't break any workflow with other tools I'll be glad to mention it as well.