search

OCA / maintainer-tools

Odoo Maintainers Tools & conventions for OCA members which evaluate and maintain repositories.
GNU Affero General Public License v3.0
270 stars 455 forks source link

Update our tooling to support Odoo 18.0 #628

Open sbidoul opened 5 days ago

sbidoul commented 5 days ago

Improvements we may want to do

See #582 for links to similar PRs for 17.0.

simahawk commented 5 days ago

generate 18.0 branches (oca-create-branch), using the bot account

I'd rather add another tool on https://github.com/OCA/repo-maintainer as we need to add a branch to all repos of https://github.com/OCA/repo-maintainer-conf.

I could have a look at that. Then we can trash oca-create-branch IMO, unless you see any reason to keep it.

pedrobaeza commented 5 days ago

I have assigned to me the OCB first part and the OpenUpgrade one.

simahawk commented 5 days ago

set OCB 18.0 branch as default

same for this -> we must use the repo-maintainer. I'll include an option in the new tool mentioned above.

@pedrobaeza I take over this one if ok for you

legalsylvain commented 5 days ago

Hi @sbidoul. Thanks for enumerating all the tasks to do. The majority of tasks cannot be performed, as version 18.0 has not been released but as soon as 18.0 is released, we can go forward. The last year, the release was done october 26, 2023 : (https://github.com/odoo/odoo/commit/dd05f0af20a84658c6a57b10bc80832bd341a638) 13 days before the Odoo days. (8 - 10 November 2023)

sbidoul commented 5 days ago

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: https://github.com/OCA/maintainer-tools/pull/541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

pedrobaeza commented 5 days ago

@simahawk OK

@legalsylvain I predict this year the date will be more constrained, as they still have some big things to merge (for example, company dependent fields to JSON - let's hope it enters this version -), but maybe they still create the branch on advance even if not completed as a favor to the community.

sbidoul commented 5 days ago

@legalsylvain it's true some tasks can't be done yet. PRs can be prepared, though.

But more importantly there are the improvements mentioned at the beginning that can be worked on if we want to address them.

simahawk commented 5 days ago

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: #541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

hmm the repo-maintainer will bootstrap the branch w/o that tool. We have to find a different way likely. I'll have a look, thanks for the pointer.

simahawk commented 5 days ago

@simahawk feel free to give it a try. For oca-create-branch I used this PR last time: #541 which tries to preserve some copier answer from previous branch (not all, as we use different more modern defaults each year).

hmm the repo-maintainer will bootstrap the branch w/o that tool. We have to find a different way likely. I'll have a look, thanks for the pointer.

I had a look at your work but I think we don't need it anymore. Please see https://github.com/OCA/maintainer-tools/pull/541#issuecomment-2348122119 If that's correct, here we have the new tool to manage branches and here the result for v18

pedrobaeza commented 5 days ago

I have added a point for the migration guide.

sbidoul commented 5 days ago

I have added a point for the migration guide.

@pedrobaeza was that not the third item already?

pedrobaeza commented 5 days ago

Ouch, I didn't see it...

PabloEForgeFlow commented 4 days ago

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through https://github.com/OCA/oca-ci/issues/10 and I think I could do that, if nobody's working on it currently.

sbidoul commented 4 days ago

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through OCA/oca-ci#10 and I think I could do that, if nobody's working on it currently.

@PabloEForgeFlow cool, that is most welcome. Just checking if @rousseldenis was not planning to do the same.

rousseldenis commented 4 days ago

Hello, I was wondering if I could contribute somehow, perhaps one of the improvements mentioned above. I looked through OCA/oca-ci#10 and I think I could do that, if nobody's working on it currently.

@PabloEForgeFlow cool, that is most welcome. Just checking if @rousseldenis was not planning to do the same.

@PabloEForgeFlow You can do it as the solution proposed is simpler than mine.

Ping me if you want review.

PabloEForgeFlow commented 4 days ago

Great I'll be working on it then, thanks @sbidoul @rousseldenis.

PabloEForgeFlow commented 1 day ago

Hey @sbidoul @rousseldenis , I've implemented a first version of https://github.com/OCA/oca-ci/issues/10 in https://github.com/OCA/oca-ci/pull/77, let me know what you think.