search

OCA / maintenance

Odoo modules for businesses that implies maintenance tasks
GNU Affero General Public License v3.0
77 stars 164 forks source link

Wrong filed attribute is generating error. #329

Closed peterromao closed 9 months ago

peterromao commented 1 year ago

https://github.com/OCA/maintenance/blob/91ebb88f97b30adf4c4f527d698d9b3986e7db68/maintenance_product/models/maintenance_equipment.py#L29

This line should be:

self.partner_id = first_seller.partner_id

instead of self.partner_id = first_seller.name

pedrobaeza commented 1 year ago

You are not indicating Odoo version, but please do the PR amending the problem.

peterromao commented 1 year ago

Hello Pedro,

I am sorry about the lack of information on the version. I was in a hurry to dinner. :-)

Version is odoo 16 CE.

The code was throwing an error and I tracked it down to that line. My change seems to have done the trick.

P.S. what does do the PR mean? I am fairly new to this github thing.

pedrobaeza commented 1 year ago

PR = Pull Request, that is to contribute here with the patch.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst

github-actions[bot] commented 11 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.