search

OCA / maintenance

Odoo modules for businesses that implies maintenance tasks
GNU Affero General Public License v3.0
76 stars 160 forks source link

[15.0][IMP] maintenance_plan: Add freeze_time to prevent errors in tests #371

Closed victoralmau closed 10 months ago

victoralmau commented 10 months ago

Add freeze_time to prevent errors in tests.

Please @pedrobaeza can you review it?

@Tecnativa

victoralmau commented 10 months ago

I still feel that changing the behavior of current interval option is not OK. You should add a new one "End of month".

You are right, the previous change (end of month) should be an option to be defined to avoid the data not being as expected.

Finally I have left only the freeze_time change to make the tests more resilient.

pedrobaeza commented 10 months ago

Please check this also: https://github.com/orgs/OCA/discussions/122

OCA-git-bot commented 10 months ago

On my way to merge this fine PR! Prepared branch 15.0-ocabot-merge-pr-371-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at bb81f10a2b339535f71838331a17553e9f7a2925. Thanks a lot for contributing to OCA. ❤️