OCA / maintenance

Odoo modules for businesses that implies maintenance tasks
GNU Affero General Public License v3.0
76 stars 160 forks source link

Not many groups on maintenance #396

Open etobella opened 4 months ago

etobella commented 4 months ago

When we use maintenance, we only find two groups:

This is obviously not enough. What I would recommend:

There is a module for something similar on OCA, but it is breaking maintenance logic for several reasons:

This is not fitted for a big company with several teams on different areas. For example, I have two teams, one for Building Maintenance and another for IT. We don't want to mix issues between them, but users might be able to create issues on both teams.

I can see two options:

  1. Create a new module
  2. Reorganize completely the base_maintenance_group
  3. Do 1 but apply 2 on new versions

WDYT?

@astirpe @MiquelRForgeFlow [I add you because you were involved at some point with this module]

pedrobaeza commented 4 months ago

We have https://github.com/OCA/maintenance/tree/15.0/maintenance_security for having more granular control.

etobella commented 4 months ago

But it only filters menus, isn't it, Would be right to add all this permissions there?

MiquelRForgeFlow commented 4 months ago

I think 1st option is safer one.

cc: @Borruso

pedrobaeza commented 4 months ago

I think the module can be extended to add more groups.

Borruso commented 4 months ago

I think 1st option is safer one.

cc: @Borruso

Yes, create new module is better one.

pedrobaeza commented 4 months ago

cc @victoralmau didn't we do something similar?

etobella commented 4 months ago

I can create a new module, but having several strategies for the same goal seems a bad decision IMO. I would prefer to find a point of agreement in order to simplify all the flows in a single one at some point

pedrobaeza commented 4 months ago

I didn't know base_maintenance_group. What is the problem with such module? Maybe the team concept? Should this go by department?

victoralmau commented 4 months ago

IMO there is confusion (especially with module names).

My conclusions:

etobella commented 4 months ago

It has no sense to depend on base_maintenance_group:

  1. They remove access to base.group_user. I can agree on the idea, but it is a different scope and not required for all companies....
  2. A lot of security has been added on the menus
  3. filters only on teams, but it has no sense IMO