search

OCA / manufacture

Odoo Manufacturing Addons
GNU Affero General Public License v3.0
169 stars 479 forks source link

[16.0][ADD] mrp_product_characterisation #1255

Open quentinDupont opened 6 months ago

quentinDupont commented 6 months ago

Migrate from custom Grap module used in v12.0 since more than 1 year

New module for OCA

Adds characterisation "Intermediate Products" and adjust Components characterisation :+1:

For example in bakeries, leavening is a intermediate product, and buckwheat flour a component product.

intermediate_product

Add BoM filters linked to this new characterisation

quentinDupont commented 5 months ago

Does it overlap with https://github.com/OCA/manufacture/blob/14.0/mrp_bom_hierarchy/model/mrp_bom.py#L100C5-L100C19 ?

Nope it doesn't seem to overlap but rather it completes it. mrp_bom_hierarchy adds informations on BoM and BoM lines and permits to navigate easily between BoM child and parents, this module adds informations on Product to better classify them

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

quentinDupont commented 2 months ago

ping @OCA/manufacturing-maintainers :-)

quentinDupont commented 2 months ago

2 things:

* If the same product cannot be both component and intermediate, what about using a Selection field instead of two Booleans?

* What about using "Finished", "Semi-finished" and "Component" as possible values instead of "Final", "Intermediate" and "Component"? AFAICS both wordings are widely used in the industry, so it's more nitpicking than anything else.

Hello and thanks for your time :)