search

OCA / manufacture

Odoo Manufacturing Addons
GNU Affero General Public License v3.0
165 stars 474 forks source link

[15.0] mrp_sale_info: Materialize link between sale order lines and created MOs #1298

Open grindtildeath opened 1 week ago

grindtildeath commented 1 week ago

Improve test with 3 steps delivery route and use RecordCapturer

OCA-git-bot commented 1 week ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 3 days ago

About the PR formal thing, please follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

About the feature itself, the module is for getting the sales info into the production. This seems bit to go in the opposite direction, isn't it?

grindtildeath commented 2 days ago

@pedrobaeza Thx I'll fix the commit message before merging.

If the goal of the module is only to provide sale information on the MO, and not MO information on the sale, we could still add the M2m field on mrp.production as well, but as it's wasn't a requirement, I did not add it...

IMO as long as the feature doesn't harm, I tend to prefer extending the scope of an existing module providing similar features than creating a dedicated module, which in turn would probably bring more confusion to end users in what each module provides.

pedrobaeza commented 2 days ago

OK, go ahead with the commit renaming.