OCA / margin-analysis

Odoo Financial Controlling (margin, costs, ...)
https://odoo-community.org/project/9
GNU Affero General Public License v3.0
74 stars 161 forks source link

[16.0][MIG] sale_margin_delivered: Migration to 16.0 #183

Closed pilarvargas-tecnativa closed 1 year ago

pilarvargas-tecnativa commented 1 year ago

Supersede: https://github.com/OCA/margin-analysis/pull/176

cc @Tecnativa TT44910

@chienandalu @sergio-teruel please review

pedrobaeza commented 1 year ago

Please do a rebase to remove the merge commit.

pedrobaeza commented 1 year ago

/ocabot migration sale_margin_delivered

pedrobaeza commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-183-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 360dd5977dc70b8ba48f850743c11735f70a6cda. Thanks a lot for contributing to OCA. ❤️

legalsylvain commented 1 year ago

Hi. I had a unanswered question here : https://github.com/OCA/margin-analysis/pull/183#pullrequestreview-1626771131 if anybody can answer... Thanks !

pedrobaeza commented 1 year ago

Hi. I had a unanswered question here : #183 (review) if anybody can answer... Thanks !

It can be an improvement, yes