search

OCA / margin-analysis

Odoo Financial Controlling (margin, costs, ...)
https://odoo-community.org/project/9
GNU Affero General Public License v3.0
71 stars 161 forks source link

[IMP] sale_margin[_delivered]_security: depend on product_cost_security #198

Closed yajo closed 5 months ago

yajo commented 6 months ago

Both modules do essentially the same thing: apply a restriction over product costs. Thus, it makes sense to share the same permission groups.

This refactor, that depends on https://github.com/OCA/product-attribute/pull/1538, improves the module readme and makes sale_margin_security auto-installable addon when product_cost_security is found.

A migration script is provided to make sure the same users still retain the same permissions.

[IMP] sale_margin_delivered_security: combine with product_cost_security

Following https://github.com/OCA/product-attribute/pull/1538, the security is now done via mixin and the view can be removed.

@moduon MT-5158

OCA-git-bot commented 6 months ago

Hi @sergio-teruel, some modules you are maintaining are being modified, check this out!

yajo commented 6 months ago

I set as draft until https://github.com/OCA/product-attribute/pull/1538 is merged.

legalsylvain commented 6 months ago

hi @rafaelbn, No point of view here. I don't use the _security OCA modules. In my company, product costs are open source, all people can read it ;-)

OCA-git-bot commented 6 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yajo commented 5 months ago

Thanks @Gelojr. I added that in https://github.com/OCA/product-attribute/pull/1565 because that behavior comes from the lower-level module product_cost_security.

This one should be ready to merge IMHO.

dreispt commented 5 months ago

/ocabot merge minor

OCA-git-bot commented 5 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-198-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-198-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 7f7edd6a6aa3309c149b2e83178313505e2e9deb. Thanks a lot for contributing to OCA. ❤️