search

OCA / margin-analysis

Odoo Financial Controlling (margin, costs, ...)
https://odoo-community.org/project/9
GNU Affero General Public License v3.0
74 stars 161 forks source link

[14.0][FIX] account_invoice_margin: wrong default margin calculation #201

Closed dreispt closed 7 months ago

dreispt commented 7 months ago

When installing the module, the Invoice total margin initial calculation was including all AML lines, including taxes. This resulted in a margin of more than 100%.

Example: image

OCA-git-bot commented 7 months ago

Hi @sergio-teruel, some modules you are maintaining are being modified, check this out!

legalsylvain commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA-git-bot commented 7 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 7 months ago

/ocabot merge patch

OCA-git-bot commented 7 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-201-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 0a9155163600218f4ad3d40877d1af20f7c165a9. Thanks a lot for contributing to OCA. ❤️