Closed ernestotejeda closed 5 years ago
LGTM.
Is there a need for a note in the readme about possible limitations with multiple currencies?
Travis is red, though.
Also, since the repo is new, we could configure it with the new pre-commit linting?
I'm sorry @sbidoul , I still don't know how to onfigure it with the new pre-commit linting
@ernestotejeda no problem :) I just pushed the pre-commit config. Can you rebase and run pre-commit run -a
. More explanations in the blog post.
@sbidoul Thanks for the hint. Changes done
/ocabot merge
On my way to merge this fine PR! Prepared branch 11.0-ocabot-merge-pr-6-by-pedrobaeza-bump-no, awaiting test results.
Congratulations, your PR was merged at ac0e561b391b2f5510c5340cf9441f618dc9bbc2. Thanks a lot for contributing to OCA. ❤️
Cc @Tecnativa TT14942