OCA / mis-builder-contrib

Modules that provide additional features on top of MIS Builder. A kind of incubator for MIS Builder features that may land in the core in the future.
GNU Affero General Public License v3.0
8 stars 43 forks source link

[ADD] mis_builder_analytic: New module #6

Closed ernestotejeda closed 5 years ago

ernestotejeda commented 5 years ago

Cc @Tecnativa TT14942

sbidoul commented 5 years ago

LGTM.

Is there a need for a note in the readme about possible limitations with multiple currencies?

sbidoul commented 5 years ago

Travis is red, though.

Also, since the repo is new, we could configure it with the new pre-commit linting?

ernestotejeda commented 5 years ago

I'm sorry @sbidoul , I still don't know how to onfigure it with the new pre-commit linting

sbidoul commented 5 years ago

@ernestotejeda no problem :) I just pushed the pre-commit config. Can you rebase and run pre-commit run -a. More explanations in the blog post.

ernestotejeda commented 5 years ago

@sbidoul Thanks for the hint. Changes done

pedrobaeza commented 5 years ago

/ocabot merge

OCA-git-bot commented 5 years ago

On my way to merge this fine PR! Prepared branch 11.0-ocabot-merge-pr-6-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot commented 5 years ago

Congratulations, your PR was merged at ac0e561b391b2f5510c5340cf9441f618dc9bbc2. Thanks a lot for contributing to OCA. ❤️