search

OCA / multi-company

GNU Affero General Public License v3.0
101 stars 282 forks source link

[MIG] stock_intercompany: Migration to 16.0 #493

Closed yankinmax closed 10 months ago

ivs-cetmix commented 1 year ago

Hi @yankinmax, thank you for your contribution! Could you please rebase your PR? We would like to do functional and code reviews

angelinaanaki commented 1 year ago

The code looks good to me. During the functional tests, I noticed that the 'qty_done' field of stock.move.line isn't being copied to the incoming picking. I'm uncertain whether this is intentional or a bug, as the logic for copying the stock.move.line is the same in version 15.0.

ivs-cetmix commented 1 year ago

The code looks good to me. During the functional tests, I noticed that the 'qty_done' field of stock.move.line isn't being copied to the incoming picking. I'm uncertain whether this is intentional or a bug, as the logic for copying the stock.move.line is the same in version 15.0.

This is a migration PR so we are copying all the logic "as is". If any changes are needed they can be done later in separate PRs

ivs-cetmix commented 1 year ago

Hey @OCA/intercompany-maintainers could you have a look at this please? We would like to have it merged to add some new features afterwards

legalsylvain commented 10 months ago

/ocabot merge nobump

OCA-git-bot commented 10 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-493-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot commented 10 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-493-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at b0a599cc96cf5aff6be1d73a9e592eb228488b78. Thanks a lot for contributing to OCA. ❤️

legalsylvain commented 10 months ago

/ocabot migration stock_intercompany