search

OCA / multi-company

GNU Affero General Public License v3.0
101 stars 282 forks source link

[IMP] purchase_sale_inter_company: apply customer specific changes and improve with latest changes from v14 #504

Closed yankinmax closed 5 months ago

yankinmax commented 1 year ago

This PR returns customer specific changes introduced in these commits:

This PR is opened as a replacement of the closed one: https://github.com/OCA/multi-company/pull/445

yankinmax commented 11 months ago

@SilvioC2C thanks for your review. I've analysed your suggestions and will update this PR and propose these changes in next release. AS for the PR itself: we've analysed with @gurneyalex different ways to handle customer needs. Of course the best would be to create customer specific module and override workflow, but it isn't possible in current OCA state.

SilvioC2C commented 11 months ago

@yankinmax OCA modules should not contain customer-specific needs, they should be generic enough to be included in public repos. If these changes are customer-specific, they should be made directly in the customer's project.

Besides, these comments are about bugs that break the execution of Odoo itself, so they should be fixed regardless:

  1. https://github.com/OCA/multi-company/pull/504#discussion_r1403569549
  2. https://github.com/OCA/multi-company/pull/504#discussion_r1403571288
  3. https://github.com/OCA/multi-company/pull/504#discussion_r1403571727
yankinmax commented 11 months ago

@SilvioC2C I agree with you. It was a difficult decision we've taken with @gurneyalex We had two options using standard purchase sale intercompany flow or OCA one. The customer wanted OCA variant, but with his specific needs. What we could do, we could have customer module with overwritten code. I'll propose that to the BA Thanks again for your help and impact on these questions

legalsylvain commented 10 months ago

@SilvioC2C, is it ok now ?

SilvioC2C commented 10 months ago

@legalsylvain unfortunately no, there still are bugs in this code and it still includes customer-specific behavior :sweat_smile:

github-actions[bot] commented 6 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.