search

OCA / multi-company

GNU Affero General Public License v3.0
100 stars 281 forks source link

[16.0][ADD] account_reconcile_model_multicompany_propagate #515

Closed EmilioPascual closed 9 months ago

EmilioPascual commented 11 months ago

Allow propagate reconcile model to other companies with same chart template.

https://www.loom.com/share/1d4c0856e990467087e9e824477784c8

@yajo @Shide @loida-vm @ArantxaSudon @rafaelbn please review, if you want 😉. Thanks.

MT-3690 @moduon

EmilioPascual commented 11 months ago
  • Texto de aviso: Da a entender si se comparte el plan de cuentas, y un plan de cuentas no se puede compartir, es específico para cada compañía. Sugiero: "This will copy this model to other companies that the user has access to. It will copy the account, in case it belongs to the generic chart of accounts. If they already have a model with the same name, it will be updated in place. Are you sure to proceed?"

@yajo has already requested a change in confirm text, but i forgot update translation to spanish. If you test module in spanish, you didn't see right confirm text. I have just update spanish translation

  • ¿Podría contener un campo el modelo para indicar "Compañía"? Si este campo está establecido con la compñía a la que queremos que el modelo pertenezca, entonces no permitir que se propague. Evitará errores.

I think it's strange behaviour, maybe a wizard where you select companies with same CoA. What do you think? @loida-vm @rafaelbn

loida-vm commented 11 months ago

I think it's strange behaviour, maybe a wizard where you select companies with same CoA. What do you think?

I think that having a wizard with that behaviour doesn't make sense. Maybe, the mistake is already avoided when the confirmation window comes out.... What is your opinion @rafaelbn ?

loida-vm commented 11 months ago

Funtional review done. LGTM!! Thanks @EmilioPascual

OCA-git-bot commented 9 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

EmilioPascual commented 9 months ago

@gurneyalex, @JordiBForgeFlow or @jgrandguillaume can you merge please?

legalsylvain commented 9 months ago

/ocabot merge patch

OCA-git-bot commented 9 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-515-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 46018218cd923f2c3e777e6aa9194f760f14ba98. Thanks a lot for contributing to OCA. ❤️