search

OCA / multi-company

GNU Affero General Public License v3.0
101 stars 282 forks source link

purchase_sale_inter_company: fix validation of several picking. self can have more than one record #523

Closed sebastienbeau closed 10 months ago

sebastienbeau commented 1 year ago

If you try to validate more then one picking. It will raise an error. Refactor the code to fix the incompatibility, and clean it to make it simplier and more readable

Fix pr : https://github.com/OCA/multi-company/pull/507

sebastienbeau commented 1 year ago

@renda-dev

francesco-ooops commented 1 year ago

@sebastienbeau since we put some effort in writing tests for #507 , can I ask you to increase coverage for this fix too?

Thank you!

sebastienbeau commented 11 months ago

@francesco-ooops, I have added the test and done a rebase, it's should be ready for the merge, it's ok for you ?

OCA-git-bot commented 10 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bguillot commented 10 months ago

/ocabot merge patch

OCA-git-bot commented 10 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-523-by-bguillot-bump-patch, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at 91f12da3166b1e1010a2422df10abe01ac365f30. Thanks a lot for contributing to OCA. ❤️