search

OCA / multi-company

GNU Affero General Public License v3.0
100 stars 281 forks source link

[14.0] ir_config_parameter_multi_company implementation #534

Closed deniscraciungabriel closed 6 months ago

eLBati commented 8 months ago

Hi @legalsylvain thanks for your feedback.

We considered that implementation, but, as ir.config_parameter contains the constraint ('key_uniq', 'unique (key)', 'Key must be unique.'), having a company_id field would imply to have duplicated key; and modifying the SQL constraint seemed too much invasive.

legalsylvain commented 8 months ago

modifying the SQL constraint seemed too much invasive.

Well, I allready saw some overload of SQL constraint in OCA modules. that is not hard to do, and it makes the code very much simpler. what is the drawback you think ?

eLBati commented 7 months ago

@legalsylvain thanks. Then, I would close this in favour of https://github.com/OCA/multi-company/pull/574