OCA / multi-company

GNU Affero General Public License v3.0
100 stars 281 forks source link

[16.0][MIG] pos_restaurant_multi_company #537

Closed legalsylvain closed 3 months ago

legalsylvain commented 9 months ago

Trivial migration.

Description

This module adds support for multi company on Point of Sale restaurant module.

legalsylvain commented 8 months ago

/ocabot migration pos_restaurant_multi_company

github-actions[bot] commented 3 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza commented 3 months ago

Please indicate first what is your investigation and why you are declaring as rebel the other module instead of yours.

legalsylvain commented 3 months ago

Please indicate first what is your investigation and why you are declaring as rebel the other module instead of yours.

Answered here : https://github.com/OCA/multi-company/issues/632

pedrobaeza commented 3 months ago

Well, I think you should isolate your module, not the other. Before yours coming, everything was green, and if you isolate yours, that will continue the same. Anyway, it seems that just putting at https://github.com/OCA/multi-company/blob/91b1eafbd21417610dfd3e9622b7d66947016e26/account_multicompany_easy_creation/wizards/multicompany_easy_creation.py#L196 a sudo should be enough.

legalsylvain commented 3 months ago

Well, I think you should isolate your module, not the other

Definitively not. 1) Otherwise, we have to set as rebel all the futur OCA modules that depends on pos_restaurant (or maybe other Odoo modules, who knows ?). 2) A bug should occures for the time being, in production with account_multicompany_easy_creation and pos_restaurant installed.

The problem is in account_multicompany_easy_creation not in pos_restaurant_multi_company

Anyway, it seems that just putting at ... a sudo should be enough.

Thanks for the investigation and the patch ! It is now green.

/ocabot merge nobump

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-537-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 082e749db9e89291340ed0f8de28d8cbf5159954. Thanks a lot for contributing to OCA. ❤️