search

OCA / multi-company

GNU Affero General Public License v3.0
100 stars 281 forks source link

[16.0] Error in Domain Regardless of company_ids Field State #545

Closed andrel-exo closed 1 month ago

andrel-exo commented 9 months ago

Body:

Description: While conducting tests for issue #459, I discovered a bug in a specific domain. The issue arises regardless of the state of the company_ids field - whether it is filled or left empty.

Steps to Reproduce:

Access the domain where the issue #459 is relevant. Just try to create one product

Actual Behavior: An error occurs in this domain, irrespective of the company_ids field being populated or not.

Proposed Solution: I suggest modifying the existing condition to handle both scenarios effectively. The proposed code change is as follows:

['|', ('company_ids', 'in', company_ids), ('company_ids', '=', False)]

This modification ensures that the condition correctly accounts for scenarios where company_ids are either specified or not.

Additional Comments:

I hope this is not an oversight on my part, and I appreciate any input or verification on this issue.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.