OCA / multi-company

GNU Affero General Public License v3.0
100 stars 281 forks source link

[14.0][FIX] purchase_sale_inter_company: fix demo data #555

Closed aleuffre closed 8 months ago

aleuffre commented 8 months ago

Just changing these fields to make it easier to test the module.

Technically a bug in "stock" module's demo data. Contact Jeff Lawson is also the "address" of warehouse "Chicago 1". The fields property_stock_customer and supplier are set to "Inter-warehouse transit" on Jeff Lawson for company San Francisco and not for company Chicago as it should be.

Since there are no routes set for location "Inter-warehouse transit", creating an inter-company PO from Chicago to SF fails; when the inter-company SO is automatically created, with delivery address towards the Chicago Warehouse i.e. Jeff Lawson, the creation of the SO's picking fails as there is no route available.

OCA-git-bot commented 8 months ago

Hi @renda-dev, some modules you are maintaining are being modified, check this out!

francesco-ooops commented 8 months ago

@pedrobaeza anything against? it's too late to fix it on 14 demo data

francesco-ooops commented 8 months ago

@pedrobaeza demo data are useful for functional testing and bug reporting :)

pedrobaeza commented 8 months ago

Yes, that's its purpose. Not for tests.

aleuffre commented 8 months ago

There may be a misunderstanding here. Automated tests/unit tests already work well.

This change is purely to make functional testing easier.

aleuffre commented 8 months ago

/ocabot merge nobump

OCA-git-bot commented 8 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-555-by-aleuffre-bump-nobump, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at 6f5b03a5e9d4abe743ebcfb0fdcfa832a3fe58c8. Thanks a lot for contributing to OCA. ❤️