OCA / multi-company

GNU Affero General Public License v3.0
101 stars 281 forks source link

Lack of connection to base_multi_company post_init_hook in partner_multi_company and product_multi_company modules in version 16 #571

Closed phayasqs closed 1 month ago

phayasqs commented 8 months ago

partner_multi_company v16 product_multi_company v16

In the version 16 of the partner_multi_company and product_multi_company modules, there is currently no direct connection established with the base_multi_company module through hooks. Instead, these modules hooks rely solely on writing data within record rules. However, it is important to note that the base_multi_company module contains more comprehensive post_init_hook than just writing record rules. This raises concerns about potential issues that may arise due to the absence of a more robust connection to base_multi_company?

If the decision is made to maintain the current logic of solely writing record rules in the post_init_hook(partner_multi_company, product_multi_company), I would recommend to include "active": True in the record rule write operation. This is important because, after uninstalling the partner_multi_company or product_multi_company , the associated record rules are inactive, leading to inaction of modules after their reinstalation.

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.