search

OCA / multi-company

GNU Affero General Public License v3.0
98 stars 280 forks source link

[16.0][ADD] sale_partner_company #580

Open santostelmo opened 5 months ago

santostelmo commented 5 months ago

Description

Allow to set the default selling company on a partner.

Configure

On the partner, choose the default company. Create a sale.order with this partner, the sales company will be adapted from the partner.

jbaudoux commented 5 months ago

Doesn't really depends on https://github.com/OCA/multi-company/pull/577

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

santostelmo commented 4 months ago

Pushed improvement to assign default sale company value based on default sale partner => https://github.com/OCA/multi-company/compare/0d5ece9251995ec39d435d6976871a630d4d8d8c..79fc9a1006fc2968cceb7d8208db32cd86a68df0

cyrilmanuel commented 4 months ago

hiii @pedrobaeza can you merge this PR please ?

pedrobaeza commented 4 months ago

Similar to #584, I think the name should be partner_selling_company

jbaudoux commented 4 months ago

Similar to #584, I think the name should be partner_selling_company

It depends on sale and modifies sales order behavior. It's not just a partner attribute. in my opinion, current name is correct

cyrilmanuel commented 3 months ago

Hello @pedrobaeza and @jbaudoux , Could you agree on this or on the changes to be made?

pedrobaeza commented 4 weeks ago

I haven't blocked the PR, so you can go on if you want to.

cyrilmanuel commented 3 weeks ago

Hi @gurneyalex, could you merge this pr please :)

gurneyalex commented 2 weeks ago

/ocabot merge nobump

OCA-git-bot commented 2 weeks ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-580-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot commented 2 weeks ago

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-580-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.