search

OCA / multi-company

GNU Affero General Public License v3.0
101 stars 281 forks source link

[14.0] [FIX] purchase_sale_inter_company: wrong field #583

Closed renda-dev closed 8 months ago

renda-dev commented 8 months ago

This PR fixes a bug that was preventing the module to work properly.

Without this, an error would be raised every time that action_confirm is triggered.

OCA-git-bot commented 8 months ago

Hi @aleuffre, some modules you are maintaining are being modified, check this out!

aleuffre commented 8 months ago

Seems like the field in question existed on v12 but was changed on v14

https://github.com/OCA/OCB/commit/57f805f71e9357870dfc2498c5ef72ebd8ab7273#diff-55c6314416a6a400da6acd5018d161a55eeeb0e3008fec8828121e3dd12be0eb

aleuffre commented 8 months ago

The fix is fine.

Would recommend adding a test that covers this use case, since just executing this part of the code once would have caught the problem.

aleuffre commented 8 months ago

/ocabot merge patch

OCA-git-bot commented 8 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-583-by-aleuffre-bump-patch, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at cb84306bf080bef0644cf4462ae012e7c522338b. Thanks a lot for contributing to OCA. ❤️