OCA / multi-company

GNU Affero General Public License v3.0
98 stars 280 forks source link

[16.0][ADD] sale_product_company #584

Closed santostelmo closed 3 months ago

santostelmo commented 5 months ago

In the product template allows you to select a list of companies in which you can sell it. Note that if the product's company field is set, it takes priority over the list of companies.

Note: We could add a multi-company field company_ids on product.template with the module base_multi_company. But that it is not an option as we don't want to have any side effect on logistics or accounting flows related product selection.

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

cyrilmanuel commented 4 months ago

hiii @pedrobaeza can you merge this PR please ?

pedrobaeza commented 4 months ago

For me, the module name is incorrect, as it doesn't reflect the usual structure of them. It should be something like product_sellable_per_company, starting with product.

jbaudoux commented 4 months ago

For me, the module name is incorrect, as it doesn't reflect the usual structure of them. It should be something like product_sellable_per_company, starting with product.

I don't agree. It depends on sale and modify the behavior of the sales order. So it should start with sale. I find current name appropriate

cyrilmanuel commented 3 months ago

Hello @pedrobaeza and @jbaudoux , Could you agree on this or on the changes to be made?

pedrobaeza commented 3 months ago

Well, I already said about the module name, so I'm refraining from doing anything more. @simahawk can merge if you all agree it's a good module name.

gurneyalex commented 3 months ago

/ocabot merge nobump

OCA-git-bot commented 3 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-584-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 356e61f7d97a6621bc67b470bef136ef9957e306. Thanks a lot for contributing to OCA. ❤️