search

OCA / multi-company

GNU Affero General Public License v3.0
98 stars 280 forks source link

[14.0] [FIX] product_multi_company: inherit from multi.company.abstract #593

Closed renda-dev closed 4 months ago

renda-dev commented 4 months ago

Required behavior: Searching a record with a product that has check_company=True without any company assigned must be visible by every company.

Without inheriting multi.company.abstract the product.product model doesn't use the patched _name_search and search_read, which is essential if you want to have a relation towards product.product with check_company=True.

I've also added a test case that practically demonstrate the purpose of this PR and that it would fail without these changes.

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops commented 4 months ago

@pedrobaeza good to go? :)

pedrobaeza commented 4 months ago

/ocabot merge patch

OCA-git-bot commented 4 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-593-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at 3b5edbfbcf77f3c10bca278c683b2f593a1cdb3c. Thanks a lot for contributing to OCA. ❤️