search

OCA / multi-company

GNU Affero General Public License v3.0
98 stars 280 forks source link

[14.0][MIG] company_dependent_flag: Migration to 14.0 #594

Closed toita86 closed 3 months ago

francesco-ooops commented 4 months ago

@pedrobaeza good to go? :)

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 4 months ago

As this is a modification in the web client, it should be called web_field_company_dependent_flag or similar.

I also miss that the image is more focused on the adaptation and remark (with a rectangle or so) which is the change.

francesco-ooops commented 4 months ago

@pedrobaeza do you think it's convenient to rename a module existing on a latter version? I think that can be confusing and I'd rather add the requested name change to ROADMAP on most recent module version.

I also miss that the image is more focused on the adaptation and remark (with a rectangle or so) which is the change.

Could you clarify which change should/should not be applied? thanks!

francesco-ooops commented 3 months ago

@pedrobaeza doc image improved, opened PR for roadmap here

shall we merge?

pedrobaeza commented 3 months ago

/ocabot merge nobump

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-594-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 05011b83aef93e51368e2a711956dfc0f1beef1b. Thanks a lot for contributing to OCA. ❤️