search

OCA / multi-company

GNU Affero General Public License v3.0
101 stars 281 forks source link

[14.0] [IMP] purchase_sale_inter_company: remove user error on lines mismatch #596

Closed renda-dev closed 6 months ago

renda-dev commented 6 months ago

We would like to propose the remove of the UserError from this check.

The first main reason is that the ir.config.parameter to make it non-blocking it's not really user-friendly to configure. Also, there could be a lot of cases where this mismatch could happen and it would be pretty hard to go through.

cc: @chienandalu

OCA-git-bot commented 6 months ago

Hi @aleuffre, some modules you are maintaining are being modified, check this out!

aleuffre commented 6 months ago

If I remember well, I put the parameter to avoid breaking the default behavior, which was too blocking for our use cases...

So we won't miss it if it's dropped...

Another way to address it could be:

* Adding this parameter to res.config.settings

* Extra documenting the feature

As @renda-dev said, there are multiple quite common instances where the number of lines may not match, such as a partial picking with a backorder, so I think it's fair to drop the check entirely

pedrobaeza commented 6 months ago

Please fw-port it to upper versions:

/ocabot merge patch

OCA-git-bot commented 6 months ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-596-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 76c1aeab442e7d2030384a8e66f97abab43fded5. Thanks a lot for contributing to OCA. ❤️

renda-dev commented 6 months ago

Please fw-port it to upper versions

I've just checked and it seems not needed since there isn't this check in upper versions @pedrobaeza

pedrobaeza commented 6 months ago

But I think because there are more than this PR to forward-port to upper versions. You have some of them unported in fact.

francesco-ooops commented 6 months ago

@renda-dev in which PR was the check added?