[14.0][IMP] purchase_sale_inter_company: lock incoming picking validation if intercompany transfer

OCA / multi-company

GNU Affero General Public License v3.0

98 stars 280 forks source link

[14.0][IMP] purchase_sale_inter_company: lock incoming picking validation if intercompany transfer #600

Closed toita86 closed 3 months ago

OCA-git-bot commented 4 months ago

Hi @renda-dev, @aleuffre, some modules you are maintaining are being modified, check this out!

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops commented 3 months ago

@pedrobaeza merge?

Rationale for this change: do not allow purchase picking to be validated before corresponding intercompany sale picking is validated

pedrobaeza commented 3 months ago

I don't get this need. Isn't the sales order auto-confirmed when the PO is confirmed?

francesco-ooops commented 3 months ago

@pedrobaeza the sale order is confirmed but the sale order picking is not (rightfully)

so what we're doing here is to prevent Purchasing company from receiving products that Selling company hasn't shipped

pedrobaeza commented 3 months ago

OK, understood.

/ocabot merge minor

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-600-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 64f0773905ef3b10ec55bf8bff04e80a6de1001d. Thanks a lot for contributing to OCA. ❤️