search

OCA / multi-company

GNU Affero General Public License v3.0
97 stars 279 forks source link

[14.0][FIX]company_dependent_flag: fixed missing label #621

Closed toita86 closed 1 month ago

toita86 commented 1 month ago

Before this fix in the pop-up window for creating contacts, the phone field was missing the label. By not updating at every iteration the existing labels its possible to have more than two element with the same label have the flag

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops commented 1 month ago

@pedrobaeza what do you say?

@bealdav as module author too :)

pedrobaeza commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-621-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at f124464740a3a52b3c2fcc9909d389ade31ff0c9. Thanks a lot for contributing to OCA. ❤️

toita86 commented 1 month ago

@bealdav

Needs to forward port in 16.0

By checking on the runboat, the issue fixed by this PR is absent, Imo there is no need to increase the complexity of the module by doing a fwp.

bealdav commented 1 month ago

Nice to checked, thanks a lot @toita86 .