search

OCA / oca-addons-repo-template

OCA Repository Template
MIT License
61 stars 89 forks source link

pre-commit: some hooks not fails(pylint-odoo). ruff has something to do with it? #230

Closed celm1990 closed 10 months ago

celm1990 commented 10 months ago

Describe the bug

I made a module for example with some inconsistencies, but pre-commit with ruff not fails

To Reproduce

Affected versions: new linter with ruff

Steps to reproduce the behavior:

  1. Generate a new Repo using oca-addons-repo-template Command executed copier copy --UNSAFE https://github.com/OCA/oca-addons-repo-template.git repo_with_ruff
  2. Answer questions and enable ruff
  3. Add a module with some code and runpre-commit run -a

Expected behavior pylint-odoo must be fails because:

Additional context Please see repo where pre-commit not fail https://github.com/celm1990/repo_with_ruff/actions/runs/6841841712/job/18602672369

@sbidoul can you give feedback if any additional config is need? I only answer but not add additional_ruff_rules

celm1990 commented 10 months ago

UPDATE: I have updated the pre-commit configuration to utilize flake8 instead of ruff. Now, the check for maximum length is functioning as expected. You can view the results at the following link: https://github.com/celm1990/repo_with_ruff/actions/runs/6842006335/job/18603029663 So, It seems that 'ruff' is missing some configuration @sbidoul?.

However, there is an issue with pylint-odoo; I observed a new release https://github.com/OCA/pylint-odoo/releases/tag/v9.0.1 but the repository is currently using https://github.com/OCA/pylint-odoo/releases/tag/v8.0.19

celm1990 commented 10 months ago

UPDATE 2: pylint-odoo 7.0.2(used to Odoo V16) is working, So I suspicious some change from 7.0.2 to V8.0 is not working @moylop260 can you review please, I not found CHANGELOG on pylint-odoo. To v8.0.5 is working, any this commits is related https://github.com/OCA/pylint-odoo/compare/v8.0.5...v8.0.6 image

see https://github.com/celm1990/repo_with_ruff/actions/runs/6842135353/job/18603271696

sbidoul commented 10 months ago

I'm enabling E501 in #231

Regarding pylint-odoo, I don't see how its behaviour could be influenced by the ruff config. What make you think it does?

As far as I can tell, the configuration is identical as for 16.0 (no one proposed enhancements for 17), so if a problem is present, it was likely present in 16 too.

celm1990 commented 10 months ago

I'm enabling E501 in #231

Thanks so much

Regarding pylint-odoo, I don't see how it's behaviour could be influenced by the ruff config. What make you think it does?

I'm suspicious, but based on my latest comment, the change from v8.0.5 to v8.0.6 could alter behavior, possibly due to this commit. Sorry for mixin with ruff

celm1990 commented 10 months ago

I close this issue