search

OCA / oca-addons-repo-template

OCA Repository Template
MIT License
61 stars 89 forks source link

[IMP] upgrade pylint version to 9.0.4 to support Odoo 17.0 #235

Closed celm1990 closed 9 months ago

celm1990 commented 10 months ago

see https://github.com/OCA/pylint-odoo/pull/477

@pedrobaeza @sbidoul could you please review this?

sbidoul commented 10 months ago

This change applies to 16 too. Do we risk making existing 16.0 branches red due to this?

celm1990 commented 10 months ago

This change applies to 16 too. Do we risk making existing 16.0 branches red due to this?

@sbidoul but for 16 it is working, because 16.0 already is into DFTL_VALID_ODOO_VERSIONS https://github.com/OCA/pylint-odoo/blob/d5888089eac660ebb6c06f33e3ed5655c409eb72/src/pylint_odoo/misc.py#L19-L33

celm1990 commented 10 months ago

@sbidoul, my apologies for the confusion. I have revised the code to align with your reference.

yajo commented 10 months ago

Do we risk making existing 16.0 branches red due to this?

Is this question really relevant today?

In old times, when linting was centralized in MQT, a single update there could set many branches red.

Now with the copier template, you only break things if and when you update the template in a branch. At that moment in time, you have the chance to apply auto or manual fixes, and then push the new green branch that satisfies any new rules.

So, do we really need to care that much now about backwards compatibility? 🤔

sbidoul commented 10 months ago

Is this question really relevant today?

I think it is. Sometimes we need to do a mass update (like we recently did for 14, 15, 16, which caused a lot of troubles).

I think we must reach a situation where the list of lint checks is explicit and not dependent of the specific version of the linters.

celm1990 commented 10 months ago

@sbidoul Can we get this merged, at least for new repositories (from OCA or personal ones)? I understand that a mass update to existing OCA repositories may not necessarily occur. Is there anything we can improve in the pull request (PR) to facilitate the merge?