search

OCA / oca-addons-repo-template

OCA Repository Template
MIT License
61 stars 89 forks source link

[IMP] Set OCA_ENABLE_CHECKLOG_ODOO by default starting with Odoo 18.0 #271

Closed PabloEForgeFlow closed 3 days ago

PabloEForgeFlow commented 1 week ago

@sbidoul I added a question for the setting, it does seem more appropriate.

Regarding version 18.0, now that both the odoo and ocb branches are up, is there something keeping us from adding support here in the template, besides the oca-ci images not existing yet? Let me know if I can help somehow.

sbidoul commented 1 week ago

Thanks! Just a minor remark.

Regarding version 18.0, now that both the odoo and ocb branches are up, is there something keeping us from adding support here in the template, besides the oca-ci images not existing yet? Let me know if I can help somehow.

We can move forward with that yes. The part that requires most effort is modernizing the linter versions and configs, including pylint-odoo and friends.

sbidoul commented 3 days ago

@PabloEForgeFlow this does not always work, because the you added the new env variable in an already conditional section. See https://github.com/OCA/server-env/blob/18.0/.github/workflows/test.yml