search

OCA / oca-addons-repo-template

OCA Repository Template
MIT License
61 stars 89 forks source link

[FIX] Move enable_checklog_odoo check outside of nested conditional #275

Closed PabloEForgeFlow closed 1 day ago

PabloEForgeFlow commented 2 days ago

@sbidoul as you mentioned on https://github.com/OCA/oca-addons-repo-template/pull/271, I made enable_checklog_odoo depend on the outer condition.

I fixed that and took the liberty of doing a little refactor to avoid cluttering the outer conditional and improve the clarity of the template, I don't know if it did. Let me know what you think.

sbidoul commented 1 day ago

Sounds good.

The jinja2 docs talks about a do statement that looks cleaner, but I don't know what it takes to enable that. It looks like it's a "extension".

So let's move ahead with this version.

PabloEForgeFlow commented 1 day ago

The jinja2 docs talks about a do statement that looks cleaner, but I don't know what it takes to enable that. It looks like it's a "extension".

It appears that copier allows enabling extensions in the copier.yml file. If there's no drawback to enabling it I guess we could do that.