search

OCA / oca-addons-repo-template

OCA Repository Template
MIT License
61 stars 90 forks source link

repos_with_ids maintenance #87

Closed sbidoul closed 2 years ago

sbidoul commented 2 years ago

This template needs maintainer tools' repos_with_ids.txt to generate the runbot link. To this ends it vendors it as a submodule. The problem with this approach is that this submodule reference must be updated whenever we add a repo in repos_with_ids.txt.

Is there another approach possible with copier ?

sbidoul commented 2 years ago

Actually, we should get rid of this repos_with_ids hack. We should generate a runbot link that includes the repo name, and let any necessary redirection on runbot side.

pedrobaeza commented 2 years ago

Last time we checked that, runbot wasn't able to do that.

sbidoul commented 2 years ago

At the minimum, we can do the redirection in runbot's nginx.

In the meantime I've updated the vendored maintainer tools in 95c8a24d1d6a21ea5d8208433e18e519a5fb4f92

pedrobaeza commented 2 years ago

But are we going to maintain runbot at the end? I understood that you were working in another thing (runboat?).

sbidoul commented 2 years ago

Yes, I'm experimenting with something simple based on kubernetes. It's not ready yet but looks promising. The problem with runbot is that it's becoming a monster that does everything conceivable automation for Odoo SA which do not necessarily align with our needs.

In any case if we change runbot (to runboat or a runbot upgrade), the URLs and repo ids will probably change, so some kind of redirection on runbot side will be necessary.

So it is time to progressively retire repos_with_ids, I think. AFAICT, they are used

pedrobaeza commented 2 years ago

Well, changing this template and applying to the suitable repos + changing the README generator and applying it the same will replace all runbot links (and we should also change the nomenclature on for example the badge), so I think the redirection may not be necessary. All depends on the needed effort to make it work. If it's not too much, then why not. But if it takes a lot, better to focus on perform the other change IMO.

I think the runbot ID is not used in the github connector for anything.

yajo commented 2 years ago

Actually, we should get rid of this repos_with_ids hack. We should generate a runbot link that includes the repo name, and let any necessary redirection on runbot side.

This seems a good solution indeed.

Regarding the runbot change, although a bit off-topic... Have you considered Gitpod? OK, I know that it's more suited for quick disposable development environments, but actually it allows to bootstrap a sicekick service automatically and notifying the user. Just let me showcase how it works in copier itself and I think you'll get the point:

https://user-images.githubusercontent.com/973709/140029892-34043307-b656-458e-9906-6aa639ea900f.mp4

It's also free for FLOSS projects, and it's FLOSS itself, runnable on Kubernetes. And you can use the browser extension, which allows you to open a PR on gitpod in a single click, and it checks out a branch to push directly to the PR if you have permissions.

It's really quite amazing.

github-actions[bot] commented 2 years ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

sbidoul commented 2 years ago

This was done in https://github.com/OCA/oca-addons-repo-template/pull/91