OCA / oca-ci

Container image to run OCA CI tests
MIT License
30 stars 42 forks source link

Allow to configure deb build dependencies by repository #42

Open SirTakobi opened 1 year ago

SirTakobi commented 1 year ago

Is your feature request related to a problem? Yes, some modules require pip packages that require deb packages in order to be installed. An example is in https://github.com/OCA/server-tools/blob/10.0/base_external_dbsource_odbc: it depends on pyodbc (https://pypi.org/project/pyodbc) that needs unixodbc-dev, as explained in its documentation https://github.com/mkleehammer/pyodbc/wiki/Install#installing-on-linux

Describe the solution you'd like Configure apt packages on a per-repo basis that will be installed before installing Python libraries.

Describe alternatives you've considered A step can be added in the github actions that installs the apt packages before installing pip packages, but as far I as understand, that is discouraged. Currently there is nothing similar for runboat

Additional context Similar to https://github.com/OCA/oca-ci/issues/33. I ran into this while trying to add https://github.com/OCA/oca-addons-repo-template to https://github.com/OCA/server-tools/tree/10.0 in https://github.com/OCA/server-tools/pull/2486. There is some discussion already in https://discord.com/channels/737652535149592587/761225067798462465/1067129843130581083

sbidoul commented 1 year ago

I'm not sure it's worth the additional complexity. In practice this happens rarely, as more and more projects publish wheels on PyPI.