search

OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
42 stars 60 forks source link

Remove MAINTAINER_ROLE_PAGE variable #157

Closed tafaRU closed 2 years ago

tafaRU commented 2 years ago

This variable is no longer used after https://github.com/OCA/oca-github-bot/pull/139

sbidoul commented 2 years ago

Thanks! Note this part is currently disabled on OCA because it was too noisy (we should not show the message on each PR) and sometimes incorrect (showing the message when the author is already maintainer ?).

tafaRU commented 2 years ago

Note this part is currently disabled on OCA because it was too noisy [-CUT-]

Ok, thanks for pointing this out.

Just out of curiosity: how was this done?

sbidoul commented 2 years ago

@tafaRU this is in https://github.com/OCA/oca-github-bot/blob/master/src/oca_github_bot/tasks/mention_maintainer.py.

See also #150 and #153

tafaRU commented 2 years ago

Thanks @sbidoul!

tafaRU commented 2 years ago

@sbidoul sorry to bother you again but I didn't understand which part you mean with:

his part is currently disabled on OCA

Looking through last commits I can only see https://github.com/OCA/oca-github-bot/commit/1e444b6c98ada019999bd7d73d89cd201bffcf54, is it about this?

With reference to https://github.com/OCA/oca-github-bot#id1, the following feature:

Comment with a call for maintainers if there are no declared maintainer.

is still there, right?

sbidoul commented 2 years ago

Yes it's there. But on the oca instance, ADOPT_AN_ADDON_MENTION is not set, so get_adopt_mention returns nothing and therefore it is silent.

tafaRU commented 2 years ago

Now I got it :wink: Thanks @sbidoul!