OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
40 stars 57 forks source link

CLA Bot should check also on deactivated partners #170

Closed pedrobaeza closed 2 years ago

pedrobaeza commented 2 years ago

If not, ex-exployees with their proper CLA are shown as missing when doing migrations.

sbidoul commented 2 years ago

Duplicate of https://github.com/OCA/oca-github-bot/issues/209 and wrong project.

gurneyalex commented 2 years ago

well actually not the wrong project @sbidoul : https://github.com/OCA/oca-github-bot/tree/clabot ;)

sbidoul commented 2 years ago

@gurneyalex yes, sure I remember that PR. But do we want to finish that one, or rather keep the existing bot on life support and invest time in setting up a paperless CLA process ?

gurneyalex commented 2 years ago

this is actually the branch where the source code of the legacty runbot is living. There was another PR to migrate it to the gitbot, but we decided against it in the end.

I'm all in favor of setting up a paperless CLA process ;)

gurneyalex commented 2 years ago

(and killing the legacy runbot)

sbidoul commented 2 years ago

this is actually the branch where the source code of the legacty runbot is living

Oh, ah, TIL. Good to know. I was mixing with https://github.com/OCA/maintainer-tools/blob/master/tools/github_clabot_hook.py.

pedrobaeza commented 2 years ago

And meanwhile can we include deactivated partners? It shouldn't be too hard.

gurneyalex commented 2 years ago

@pedrobaeza yes I just did so

pedrobaeza commented 2 years ago

Thanks!