OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
40 stars 57 forks source link

Add command for asking review and remove "need fixing" flag #188

Open sebastienbeau opened 2 years ago

sebastienbeau commented 2 years ago

Is your feature request related to a problem? When somebody open a PR and after the review I flag it with "need fix". I would like that this person can be able to remove this tag and flag it "need review" when it's work is ready.

Describe the solution you'd like One possibility is to add to the bot a new command "/ocabot ask-review" This will remove the flag "need fix" and tag it "need review"

So maintainer can focus on PR that only "need review"

Describe alternatives you've considered giving more right on label to PR owner, but we do not want them to change all label

Additional context I ready to contribute it, I just want to know if it's a good or bad idea or if I just do not use the right process.

Thanks for your feedback

@sbidoul @legalsylvain

legalsylvain commented 2 years ago

Hi @sebastienbeau. At first sight, I see it as a great idea, but after consideration, I'm asking to me if it is "an OCA workflow".

See

Is "need fixing" label really used ? or maybe it depends on each maintainers team...

legalsylvain commented 2 years ago

@sebastienbeau : what do you think regarding my last remarks ?