search

OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
40 stars 57 forks source link

Merging PR should mark a line in the "Migration to version xx" issue as done. #189

Closed legalsylvain closed 1 year ago

legalsylvain commented 2 years ago

Ref : talk here with @pedrobaeza

Event : on pull_request / merged

Action :

  1. check in all the comments of the PR if one contains the order /ocabot migration yyy
  2. if yes, find the issue named "Migration to version xx"
  3. if found, find the line name "- [ ] yyy - By @xxx - PR ref"
  4. if found replace "- [ ]" by "- [x]"

Regarding step 1, I think it's going to be a little heavy to do that, but I don't see any alternative to identify the yyy (module name).

Comments welcome.

pedrobaeza commented 2 years ago

Instead of 1, I think it's better to just go to the migration issue of the target branch, and look for a line with the PR number. If found, mark it if not already done.

legalsylvain commented 2 years ago

Instead of 1, I think it's better to just go to the migration issue of the target branch, and look for a line with the PR number. If found, mark it if not already done.

:100: Indeed ! Thanks.