Closed legalsylvain closed 1 year ago
legalsylvain
commented
1 year ago Hi. @SirTakobi : I merged your Proposal. Thanks, and sorry for the delay. @all : I deployed this PR on my bot and the feature works correctly. (Ref : https://github.com/grap/grap-odoo-custom/issues/279)
I think it could be merged safely.
pedrobaeza
commented
1 year ago @sbidoul this one is very interesting to be merged and deployed for synchronizing the issue information with the reality.
OCA-git-bot
commented
1 year ago This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
legalsylvain
commented
1 year ago /ocabot rebase
OCA-git-bot
commented
1 year ago Congratulations, PR rebased to master.
legalsylvain
commented
1 year ago /ocabot rebase
OCA-git-bot
commented
1 year ago Congratulations, PR rebased to master.
pedrobaeza
commented
1 year ago Bravo! Are you going to deploy this for doing some checks on real scenarios?
sbidoul
commented
1 year ago @pedrobaeza it is now deployed.
pedrobaeza
commented
1 year ago Thanks. I'll check and tell you back if anything wrong.
pedrobaeza
commented
1 year ago It seems not working:
The merge process could not be finalized because an exception was raised: _find_issue() missing 1 required positional argument: 'target_branch'.https://github.com/OCA/server-backend/pull/202
cc @legalsylvain @sbidoul
Rational
When maintainers are merging migration PR, they have to manually go to the according migration issue, and check the according line. This operation is sometimes forgotten, and could be automated.
This PR introduces that feature.
Fix : #189 Discussion reference : https://github.com/OCA/OpenUpgrade/issues/3288#issuecomment-1157007829
CC : @sbidoul, @pedrobaeza
Tested with ngrox : See edited migration issue by the bot here : https://github.com/grap-org-test-bot/github-ocabot-test/issues/27 (1 July 2022 17h46)