search

OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
39 stars 57 forks source link

Missing CLABOT comment on PR by contributor without CLA #204

Closed StefanRijnhart closed 1 year ago

StefanRijnhart commented 1 year ago

Module

clabot

Describe the bug

I expected CLABOT to post a comment about the missing CLA for the submitter of https://github.com/OCA/crm/pull/441. This is a new member on my team who has not yet submitted a CLA (I also checked the OCA database and I could not find any).

legalsylvain commented 1 year ago

Hi @StefanRijnhart. thanks for reporting. AFAIK, it is not a bug, but more a missing feature. AFAIK, oca-github-bot doesn't handle cla bot check. you can take a look on this closed PR : https://github.com/OCA/oca-github-bot/pull/31

StefanRijnhart commented 1 year ago

Oh, ok. So where does the code for the clabot live currently?

legalsylvain commented 1 year ago

I dont know ! @sbidoul, @gurneyalex ?

sbidoul commented 1 year ago

So where does the code for the clabot live currently?

Actually, the current clabot lives on the clabot branch of this repo.

It looks it was broken since this commit on Apr 6, and I attempt to fix it in https://github.com/OCA/oca-github-bot/pull/205 (currently deployed on the OCA server).

Let's see if things improve.