search

OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
39 stars 57 forks source link

Not needed POT updates #227

Closed pedrobaeza closed 1 year ago

pedrobaeza commented 1 year ago

Look at this POT update commit:

https://github.com/OCA/l10n-spain/commit/6a2ab188198bcd4bbbb1c7c00a0b05ca7ae77167

It's not changing anything valuable, but it requires another CI to be launched, provoking commit noise and delay on the merges.

Can this be avoided?

sbidoul commented 1 year ago

This is not the right project for this issue. It might be click-odoo-contrib or, more likely, Odoo itself, or the library it uses to generate pot files.

pedrobaeza commented 1 year ago

I don't know who generates it, but do you agree it's a problem?

sbidoul commented 1 year ago

Not sure. Where do these two lines it is removing come from?

pedrobaeza commented 1 year ago

I launched the ocabot command for merging in https://github.com/OCA/l10n-spain/pull/2574, and on the merge branch, such commit was added. I suppose that the bot launches POT+PO update in some moment.

sbidoul commented 1 year ago

Was due to en.po being present. So closing.