search

OCA / oca-github-bot

The GitHub Bot of the Odoo Community Association (OCA)
MIT License
41 stars 60 forks source link

CLA bot: Handling of old users #28

Open pedrobaeza opened 5 years ago

pedrobaeza commented 5 years ago

@gurneyalex there's a problem with CLAbot handling all users. Check the first commit of PR https://github.com/OCA/stock-logistics-workflow/pull/482:

seleccion_064

There's no GitHub account associated with it. Why? Because that person is no longer working on the company and the account was deleted/unlinked to that email address.

I tried to add the contact with the email and with the CLA tag in our DB, but it's not enough for removing the warning.

Can we look for commit e-mail instead of looking for GitHub account in these cases?

seleccion_065

sbidoul commented 5 years ago

Looking at commit emails may not solve the problem, because people commit from different machines where they have different emails configured, not necessarily related to what is present in the OCA database.

Related: people can and do change company without changing their github login. So you can imagine one contributor covered by an ECLA changing to a situation where she/he is not covered by any CLA but keeping the same github login.

It's not an easy problem to solve. To do it properly do we need a kind of table linking github logins + emails with an (E|I)CLA together with some kind of validity period?

pedrobaeza commented 5 years ago

@sbidoul in this case, there's no GitHub login, because it seems Laetitia removed the company email from her profile when she left the company.

I don't see special problem on looking first for a CLA using GitHub login if present, but if not, then use the email address.

The table with validity period is no solution because we are reintroducing same commits on each branch, but any way, it's not a special problem, as when you sign a CLA, it's forever unless you revoke that signing.

I would say more: we are doing the contrary of Odoo, that is looking for email for their CLA, and it's the logic thing: GIT has emails, not GitHub accounts. We are doing an alien operation.

About what you say doing commits from several machines, you should stick to the same committer email address or sign several CLAs per email IMO.

pedrobaeza commented 5 years ago

@gurneyalex did you check this?

gurneyalex commented 5 years ago

@pedrobaeza not yet. I need to find time to deploy the updated cla bot first (the migration to the gitbot framework) and I'm currently struggling with a huge golive aftermatch...

pedrobaeza commented 5 years ago

OK. This is happening all days with the new PRs, so it's kind of urgent, but right now I'm simply ignoring all these messages. The problem is that one that is correct being ignored also.