search

OCA / oca-weblate-deployment

6 stars 12 forks source link

Endless loop in POT/PO update regeneration #14

Closed pedrobaeza closed 1 month ago

pedrobaeza commented 1 month ago

Not sure if this is something of the Weblate components, or git bot, so I put it here and you tell me: in the repository OCA/social (https://github.com/OCA/social/commits/16.0/), there's an endless loop updating the POT, and the updating the PO, and redone again the POT, and so one:

imagen

This is provoking a lot of noise, and undesired activity (we already needed a lot of work to bring commit history for the 17.0 version).

sbidoul commented 1 month ago

TL;DR: I think the bug is in Odoo.

.pot is generated with click-odoo-makepot after tests by the GitHub workflow action.

click-odoo-makepot uses the standard odoo function to export .pot file.

So in this case, it seems Odoo is not generating the same result in different runs of the .pot export on what should normally be the same database. Weblate aligns the .po with the .pot and pushes the changes which triggers a new build, etc.

pedrobaeza commented 1 month ago

@HydrionBurst maybe the order of the #. odoo-javascript comment is not deterministic? Check https://github.com/OCA/social/commit/82b8174698f584b1a101cddb2867b80fb3b0da37 for an example.

cc @chienandalu

HydrionBurst commented 1 month ago

@HydrionBurst maybe the order of the #. odoo-javascript comment is not deterministic? Check OCA/social@82b8174 for an example.

cc @chienandalu

Oh, yes, it was a problem. I make a backport pr for 16.0 https://github.com/odoo/odoo/pull/172896

pedrobaeza commented 1 month ago

Thank you very much, Chong!

Closing this one then, as it will be sorted with the Odoo patch.