search

OCA / odoo-community.org

The Odoo Community Association Website
http://odoo-community.org
Creative Commons Attribution 4.0 International
91 stars 123 forks source link

W7936 is triggered when a package name is different from the import #75

Open bartvanbossche-dynapps opened 1 year ago

bartvanbossche-dynapps commented 1 year ago

In one of our modules we're using the python library 'smbprotocol'. This is a wrapper for smbclient functions. In our manifest we have the following external dependencies: "external_dependencies": {"python": ["smbprotocol"]}, However, in the python files we import smblient: import smbclient When we run pre-commit we get the following warning: xx_base_integration/models/integration.py:1: [W7936(missing-manifest-dependency), ] Missing external dependency "smbclient" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies

sbidoul commented 1 year ago

IIRC this is just a warning and this check has been disabled in latest version of the repo template.