OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another
GNU Affero General Public License v3.0
123 stars 112 forks source link

PRs conflicts #39

Closed yelizariev closed 3 years ago

yelizariev commented 3 years ago

Design of the tool doesn't fit well for contributing: if there are 5 pull request about the same migration (e.g 13 to 14) and all them target the same place of code, then merging one of them leads to conflicts in all others. Well, fixing a conflict not that difficult, but

To resolve this, I would suggest to collect rules in separate files, rather than in a dictionary like _TEXT_ERRORS. It may have the following structure:

/migration_scripts/13_14/text_errors/some_name.json /migration_scripts/13_14/text_errors/another_name.json

legalsylvain commented 3 years ago

Hi @yelizariev that is a great idea. do you want to propose a PR ?

thanks !

yelizariev commented 3 years ago

Yes, I'll do it some day... I can potentially do it on top of https://github.com/OCA/odoo-module-migrator/pull/28 (and make it with less changed files https://github.com/OCA/odoo-module-migrator/pull/28#discussion_r509254275)

yelizariev commented 3 years ago

Done in #42

image

rvalyi commented 3 years ago

raptor-42-665x336