useful unfinished PRs from @flachica

OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another

GNU Affero General Public License v3.0

123 stars 112 forks source link

useful unfinished PRs from @flachica #40

Open yelizariev opened 3 years ago

yelizariev commented 3 years ago

[ ] https://github.com/OCA/odoo-module-migrator/pull/37/ multicompany 13.0
[ ] https://github.com/OCA/odoo-module-migrator/pull/31/ _TEXT_WARNINGS support (+ examples)
[ ] https://github.com/OCA/odoo-module-migrator/pull/28 Refactoring to convert script into classes
[ ] https://github.com/OCA/odoo-module-migrator/pull/26 properly handle <openerp><data noupdate="0">
[ ] https://github.com/OCA/odoo-module-migrator/pull/21 r"ir.needaction_mixin": "mail.activity.mixin",

pedrobaeza commented 3 years ago

@flachica any reason for closing all your PRs?

flachica commented 3 years ago

I have seen that with my current workload I will not be able to improve the PR made in a reasonable time. I have also seen that there are contributions from other colleagues to whom my PR would generate many conflicts, such as #28. The #31 for example, you have to change the focus in favor of another PR. Things like that. Thanks for the interest

pedrobaeza commented 3 years ago

OK, it's a pity to hear that your company doesn't reserve you time for OCA.

flachica commented 3 years ago

Well, that's not entirely accurate. What I say that my current load is going to prevent me from putting hours in the short term. I prefer to close the PR and incorporate what is necessary after a while. I really liked this approach and this would make me tweak some PR's. New PR's will arrive and not only in this repository.

pedrobaeza commented 3 years ago

Great then.