search

OCA / odoo-module-migrator

Python library to migrate odoo base code from a version to another
GNU Affero General Public License v3.0
123 stars 112 forks source link

phantom_js is not suported in v14 #50

Closed yelizariev closed 3 years ago

yelizariev commented 3 years ago

Tested here

https://github.com/itpp-labs/pos-addons/pull/1354/commits/a290c1347023a51b118272af5305b7e390fcdd8d

image

legalsylvain commented 3 years ago

Could you add a test ? Otherwise lgtm. Thanks !

yelizariev commented 3 years ago

Second commit: image

https://github.com/itpp-labs/pos-addons/pull/1354/commits/fad772e8f2a7786fb9a50f2e7e41899039fbe3fb

yelizariev commented 3 years ago

@legalsylvain maybe later

yelizariev commented 3 years ago

Though, this is straight forward replacement could be merged without unittests. Compare this with https://github.com/OCA/odoo-module-migrator/pull/38

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

This PR looks fantastic, let's merge it! Prepared branch master-ocabot-merge-pr-50-by-legalsylvain-bump-nobump, awaiting test results.

legalsylvain commented 3 years ago

thanks !

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at d7c1b8817ce0e6a7deefb04af83dc671b7413be2. Thanks a lot for contributing to OCA. ❤️